Example refactor #28
Merged
Example refactor #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchongzhang
requested review from
amrit110,
emersodb,
fatemetkl and
jewelltaylor
fatemetkl
reviewed
May 29, 2023
fl4health/utils/load_data.py
Outdated
| return train_loader, validation_loader, num_examples | ||
|
|
||
|
|
||
| def load_cifar10_data(data_dir: Path, batch_size: int) -> Tuple[DataLoader, DataLoader, Dict[str, int]]: |
Collaborator
There was a problem hiding this comment.
Suggestion: we can get a sampler object here and subsample cifar10 as well.
Collaborator
There was a problem hiding this comment.
I like Fatemeh's suggestion here. You could make the samplers Optional[LabelBasedSampler] in both load MNIST and CIFAR methods that default to none.
Collaborator
Author
There was a problem hiding this comment.
I have updated the function to include a sampler argument.
emersodb
approved these changes
May 30, 2023
Collaborator
emersodb
left a comment
emersodb
left a comment
There was a problem hiding this comment.
Looks good to go from my perspective. I'd double check with Fatemeh that this is what she had in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactoring
Short Description
For examples that use CIFAR-10, I simply moved the code for loading data to utils/load_data.py to reduce code duplication a bit, since it is also where the code for loading MNIST is located.
I considered writing a function for loading datasets in general, but that would require the client code to provide dataset-specific information which I thought might not be desirable.
Tests Added
...