Refactoring the FLamby Code and Adding Fed Heart Disease #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_disease_refactor_flamby
…_disease_refactor_flamby
…fenda implementation
…n because the models are very small
… and differences in finding the best hp values depending on experiment setup.
emersodb
requested review from
fatemetkl,
jewelltaylor,
sanaAyrml and
yuchongzhang
Collaborator
|
Sorry for the delay in the review! Hope the comments are still useful and relevant. |
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
reviewed
Jul 29, 2023
fatemetkl
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the FLamby experiments to be more re-usable for other dataset applications within the framework.
This PR also adds in the FLamby-based Fed Heart Disease experiments leveraging these refactors.
A suggestion for review would be first to concentrate of the refactors (anything that doesn't appear in the
fed_heart_diseasefolder) and then to take a look at thefed_heart_diseaseexperiments thereafter.Note: There is a lot of stuff in here. Apologies for that. While some of it is unavoidable, in the future, I'll try to break these up better. For example, in future iterations, I'll do the refactor changes first and then the FedHeartDisease additions thereafter. I sort of did them all at the same time which isn't ideal for reviewing.