-
Notifications
You must be signed in to change notification settings - Fork 16
Deep MMD MR-MTL #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep MMD MR-MTL #437
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 80.52% 79.48% -1.05%
==========================================
Files 163 164 +1
Lines 10168 10264 +96
==========================================
- Hits 8188 8158 -30
- Misses 1980 2106 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emersodb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically ready to go. Just a few small suggestions for cleanup. Again, if there isn't a good example for us to cover the new code in the main library with tests, I'm okay with bypassing them for this. One quick way to do it would be just to add it to the smoke tests without metrics (just tests whether it runs properly)
PR Type
Feature
Short Description
There is a README file on the cluster at
/projects/fl4health/kernel_experiments/README_mr_mtl.mdthat includes the addresses to the saved artifacts of these experiments, including the optimal hyperparameters.Tests Added
N/A
TODO: Add tests.