Skip to content

Conversation

@fatemetkl
Copy link
Collaborator

@fatemetkl fatemetkl commented Aug 13, 2025

PR Type

Feature

Short Description

  1. MR-MTL deep MMD implementation.
  2. Synthetic data and Cifar10 experiment codes and scripts.

There is a README file on the cluster at /projects/fl4health/kernel_experiments/README_mr_mtl.md that includes the addresses to the saved artifacts of these experiments, including the optimal hyperparameters.

Tests Added

N/A

TODO: Add tests.

@fatemetkl fatemetkl changed the title Ft/mmd d mrmtl Deep MMD MR-MTL Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (0437216) to head (9f07de2).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...clients/deep_mmd_clients/mr_mtl_deep_mmd_client.py 0.00% 131 Missing ⚠️
...ealth/clients/mkmmd_clients/mr_mtl_mkmmd_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   80.52%   79.48%   -1.05%     
==========================================
  Files         163      164       +1     
  Lines       10168    10264      +96     
==========================================
- Hits         8188     8158      -30     
- Misses       1980     2106     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically ready to go. Just a few small suggestions for cleanup. Again, if there isn't a good example for us to cover the new code in the main library with tests, I'm okay with bypassing them for this. One quick way to do it would be just to add it to the smoke tests without metrics (just tests whether it runs properly)

@emersodb emersodb merged commit 0e93a01 into main Aug 25, 2025
12 of 13 checks passed
@emersodb emersodb deleted the ft/mmd-d-mrmtl branch August 25, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants