Add train by epochs option to scaffold client #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewelltaylor
changed the title
jewelltaylor
commented
Aug 21, 2023
jewelltaylor
requested review from
emersodb,
fatemetkl,
sanaAyrml and
yuchongzhang
emersodb
approved these changes
Aug 21, 2023
Collaborator
emersodb
left a comment
emersodb
left a comment
There was a problem hiding this comment.
Other than the one comment to confirm that the updated APFL function name doesn't affect anything else, looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature | Fix | Documentation | Other() ]
Short Description
Small PR to add
train_by_epochsmethod toScaffoldClientto stay consistent withAPFLClientandFedProxClientwhich both offertrain_by_stepsandtrain_by_epochs.Clickup Ticket
Tests Added