Skip to content

Pinning Ubuntu Version#492

Merged
emersodb merged 5 commits intomainfrom
dbe/ubuntu_version
Jan 21, 2026
Merged

Pinning Ubuntu Version#492
emersodb merged 5 commits intomainfrom
dbe/ubuntu_version

Conversation

@emersodb
Copy link
Copy Markdown
Collaborator

@emersodb emersodb commented Jan 20, 2026

PR Type

Fix

Short Description

NnUnet has only been verified to work up to Ubuntu 22.04. It appears that in the newer versions of Ubuntu something goes haywire inside of NnUnet (but not in, for example Mac OS as I have verified that Nnunet works fine on my local machine).

What I propose is that we split our smoke tests into two parts. We run our non-nnunet tests on Ubuntu latest and our nnunet smokes on 22.04, at least until nnunet fixes and verifies a working implementation on higher Ubuntu versions.

Tests Added

Smokes tests actually work now?

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (c1ca946) to head (0bc9d32).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   72.88%   79.65%   +6.77%     
==========================================
  Files         166      166              
  Lines       10554    10554              
==========================================
+ Hits         7692     8407     +715     
+ Misses       2862     2147     -715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emersodb emersodb changed the title Test PR Pinning Ubuntu Version Jan 20, 2026
@emersodb emersodb requested review from amrit110 and lotif January 21, 2026 13:51
@emersodb emersodb merged commit 1f65be5 into main Jan 21, 2026
18 checks passed
@emersodb emersodb deleted the dbe/ubuntu_version branch January 21, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants