Use set_up_logging function across multiple modules#28
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes logging configuration across multiple modules by replacing direct logging.basicConfig() calls with a centralized set_up_logging() function. The primary goal is to consistently silence "[non-fatal] Tracing client error 401" errors throughout the codebase.
- Removed standalone
loggingimports andlogging.basicConfig()calls - Added
set_up_loggingfunction import and invocation - Replaced hardcoded model names with references to
AGENT_LLM_NAMESdictionary
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/2_frameworks/3_code_interpreter/app.py | Replaced logging.basicConfig() with set_up_logging() function |
| src/2_frameworks/2_multi_agent/efficient.py | Replaced logging.basicConfig() with set_up_logging() and updated model references to use dictionary |
| src/2_frameworks/1_react_rag/langfuse_gradio.py | Replaced logging.basicConfig() with set_up_logging() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Use
set_up_loggingfunction to consistently silence "[non-fatal] Tracing client error 401" errors.Tests Added
N/A