Fix unsafe pickle deserialization in reward server (CVE-2026-25873)#139
Open
Chocapikk wants to merge 2 commits intoVectorSpaceLab:mainfrom
Open
Fix unsafe pickle deserialization in reward server (CVE-2026-25873)#139Chocapikk wants to merge 2 commits intoVectorSpaceLab:mainfrom
Chocapikk wants to merge 2 commits intoVectorSpaceLab:mainfrom
Conversation
pickle.loads() on untrusted HTTP input allows arbitrary code execution (CWE-502). Replace all pickle serialization in reward_proxy.py and reward_server.py with a safe JSON + base64 format via safe_serialization.py. Ref: CVE-2026-25873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pickle.loads()/pickle.dumps()calls inreward_proxy.pyandreward_server.pywith a safe JSON + base64 serialization module (safe_serialization.py)pickle.loads()on untrusted HTTP POST bodies allows arbitrary code execution (CWE-502)safe_serializationmodule handles PIL Images, dicts, lists, tuples, and primitives without executing arbitrary code during deserializationChanged files
safe_serialization.pyreward_proxy.pypickleimports and calls withsafe_serializationreward_server.pypickleimports and calls withsafe_serializationReferences