⚡ Remove obsolete SetBatchLines to fix v2 script crash#37
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
Removes an AutoHotkey v2-incompatible performance directive from the main hotkey script to prevent a startup crash, aligning the script with v2 runtime behavior (max speed by default).
Changes:
- Removed the obsolete
SetBatchLines(-1)call from a v2 script initialization block.
💡 What: Removed the obsolete
SetBatchLines(-1)function call fromahk/Keys.ahk.🎯 Why: In AutoHotkey v2, the
SetBatchLinesfunction has been completely removed because all scripts now run at maximum execution speed by default (equivalent toSetBatchLines -1in v1, eliminating the 10ms delay between lines). Becauseahk/Keys.ahkutilizes#Requires AutoHotkey v2.0, callingSetBatchLines(-1)causes an immediate "Call to nonexistent function" runtime error, crashing the script. Removing the nonexistent function resolves the startup crash while maintaining max performance as per AHK v2's default behavior.📊 Measured Improvement:
Due to the fact that the script crashes on launch, a runtime benchmark could not be collected (and dynamically benchmarking is also restricted in this Linux environment). The improvement is theoretical but absolute: transforming the script from a non-functional crashing state to executing at AutoHotkey v2's default maximum execution speed with zero inter-line delay.
PR created automatically by Jules for task 903517936799392908 started by @Ven0m0