This repository was archived by the owner on Jun 5, 2025. It is now read-only.
VCertTknClient read zone configuration issue 115#116
Merged
marcos-albornoz merged 3 commits intomasterfrom Sep 1, 2022
Merged
Conversation
The VCertTknClient SDK methods left to work since the releases v.0.9.0 until v0.9.2 given a mistake which caused the endpoints used in the background were the specific endpoints declared for the VCertClient. Also it was created a bunch of tests to test the VCertTknClient SDK methods in order to confirm they are working correctly. Resolves: #115
marcos-albornoz
requested review from
EduardoVV and
luispresuelVenafi
as code owners
EduardoVV
approved these changes
Sep 1, 2022
luispresuelVenafi
approved these changes
Sep 1, 2022
Contributor
luispresuelVenafi
left a comment
luispresuelVenafi
left a comment
There was a problem hiding this comment.
Changes looks good
tr1ck3r
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue #115 was happening due a mistake that caused the
VCertTknClientSDK methods stop to work given in the background they started to use the declared endpoints forVCertClient.It was also added a suite of tests to test the
VCertTknClientSDK methods work correctly.