This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Password encrypt private keys when keyPassword is specified in the request#25
Merged
tr1ck3r merged 2 commits intoVenafi:masterfrom Nov 4, 2020
fullstaq-labs:feature/private-key-password
Merged
Password encrypt private keys when keyPassword is specified in the request#25tr1ck3r merged 2 commits intoVenafi:masterfrom fullstaq-labs:feature/private-key-password
tr1ck3r merged 2 commits intoVenafi:masterfrom
fullstaq-labs:feature/private-key-password
Conversation
…quest Closes #21. Also gets rid of newPemCollection(). That function is not consistently used throughout the codebase, so getting rid of it makes the code more consistent. Also gets rid of a fromResponse() overload in order to reduce the likelihood of creating a PEMCollection without passing the private key and key password. Also increases test coverage for PEMCollection to test ECDSA support.
…nencrypted code path
rvelaVenafi
approved these changes
Nov 4, 2020
Contributor
Author
|
Thanks for the review. How about a merge too? :) |
Member
|
Thank you for contributing to VCert-Java @FooBarWidget 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
Also gets rid of newPemCollection(). That function is not consistently used throughout the codebase, so getting rid of it makes the code more consistent.
Also gets rid of a fromResponse() overload in order to reduce the likelihood of creating a PEMCollection without passing the private key and key password.
Also increases test coverage for PEMCollection to test ECDSA support.