This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
Instead of getting all the projects and iterating them, now it directly calls an api method to get the zone filtered by Id. This update only works when the zone id is passed as argument. When the project_name\zone_name is passed as argument, the method still retrieves all projects and iterates over them to match the project name and zone name.
Instead of getting all the projects and iterating them, now it directly calls an api method to get the zone filtered by Id. This update only works when the zone id is passed as argument. When the project_name\zone_name is passed as argument, the method still retrieves all projects and iterates over them to match the project name and zone name.
tr1ck3r
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the readZoneConfiguration() method to use the specific api calls to retrieve the zone by Id instead of retrieving all projects and iterating over them. This optimization reduces the time required for the method to complete.
However, the update only works for zone ID's. The readZoneConfiguration also supports looking for a zone by project_name\zone_name. In this scenario, there is no other option that iterate all proijects to match the name and then iterate all project zones.