Skip to content

Linux GUI#149

Closed
RozeThorns wants to merge 2 commits into
Vencord:mainfrom
TrigonWTF:main
Closed

Linux GUI#149
RozeThorns wants to merge 2 commits into
Vencord:mainfrom
TrigonWTF:main

Conversation

@RozeThorns
Copy link
Copy Markdown

@RozeThorns RozeThorns commented Mar 3, 2025

now you can build for a linux gui thats identical to the others

jamesbt365
jamesbt365 reviewed Mar 3, 2025
View reviewed changes
Comment thread gui.go Outdated
os.Setenv("GDK_DPI_SCALE", "1")
}

win = g.NewMasterWindow("Equilotl", 1200, 800, linuxFlags)
Copy link
Copy Markdown

@jamesbt365 jamesbt365 Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just blatantly stole this from Equicord

Copy link
Copy Markdown
Author

@RozeThorns RozeThorns Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code i contributed to equicord first i also contributed here
you can compare my PRs

Update gui.go
e70d4e0 
since someone thinks i stole my own change
@RozeThorns
Copy link
Copy Markdown
Author

RozeThorns commented Mar 3, 2025

This contribution was originally done on equilotl

@RozeThorns
Copy link
Copy Markdown
Author

RozeThorns commented Mar 3, 2025 •
edited
Loading

first point is weird, some people would prefer a gui
2nd point is worse, not everyone has cli skills (people new to linux or computers in general)
3rd point is completely invalid, if theres no GUI they wont be using discord then

@Sqaaakoi
Copy link
Copy Markdown

Sqaaakoi commented Mar 3, 2025

i feel like GUI in the linux installer isn't a good idea:

  • i'm gonna assume you will be running the installer script from a CLI. why would you have a GUI window pop up
  • linux users have some basic CLI skills, at least to paste a script and use arrow keys
  • what if deranged setups where the GUI can't open

all 3 of these concerns can be solved by remembering that there are 2 builds for other operating systems, with and without gui respectively, and replicating that
do also remember that there was a linux GUI at one point (i forgot why it was removed though)

@Vendicated Vendicated closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamesbt365 jamesbt365 jamesbt365 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RozeThorns @Sqaaakoi @jamesbt365 @Vendicated