fix(installer): refresh stale _app.asar on repair#178
Closed
nghiphaam wants to merge 1 commit into
Closed
Conversation
Member
|
I don't think this "solution" makes any sense. Your other solution also made no sense, are you using AI to try to come up with solutions? Please don't. This installer codebase also isn't worked on anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord updates can leave patched installs with an outdated
_app.asar.When repairing an already patched install, the installer currently restores
_app.asarback toapp.asarunconditionally. If_app.asaris stale,the repaired install keeps using old original files and can break startup.
This change makes repair prefer the current Discord
app.asarwhen theexisting patched state is desynced, instead of resurrecting a stale
_app.asar.