Skip to content

Update README.md#21

Closed
SkyeTheDoggy wants to merge 1 commit into
Vencord:mainfrom
SkyeTheDoggy:main
Closed

Update README.md#21
SkyeTheDoggy wants to merge 1 commit into
Vencord:mainfrom
SkyeTheDoggy:main

Conversation

@SkyeTheDoggy
Copy link
Copy Markdown

Changes:

  1. Add a missing dash at step 5
  2. Modified step 4 ports to - "8080:8080" from - HOST_PORT:8080 because docker-compose was throwing error saying it's an invalid type

Changes:
1. Add a missing dash at step 5
2. Modified step 4 ports to `- "8080:8080"` from `- HOST_PORT:8080` because docker-compose was marking it as invalid type
@Vendicated Vendicated requested a review from lewisakura November 3, 2023 00:48
Comment thread README.md
backend:
ports:
- HOST_PORT:8080
- "8080:8080"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intent was that you define your own host port here, not copy and paste it literally, but it could be expressed better

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, for me it thrown error

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably because you copied and pasted it literally, which you aren't meant to do.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I understand

Comment thread README.md
- "8080:8080"
```
5. `docker compose up -d`
5. `docker-compose up -d`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker compose is correct, if it's not available you need to update your docker

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the latest docker version but when I run without the dash it outputs the docker help docs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use the desktop version tho. I run my stuff on a remote server
When I also try to run sudo apt-get install docker-compose-plugin I get E: Unable to locate package docker-compose-plugin

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it just doesn't work with my setup

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Ubuntu server at least it works could be your package list is outdated or isn't on your version for me personally I use both v1 and v2 as I'm lasy asf and have the docker-compose up -d saved

SkyeTheDoggy

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants