Skip to content

Update hash function to use SHA-256 for enhanced security#23

Closed
Celestarien wants to merge 1 commit into
Vencord:mainfrom
Celestarien:main
Closed

Update hash function to use SHA-256 for enhanced security#23
Celestarien wants to merge 1 commit into
Vencord:mainfrom
Celestarien:main

Conversation

@Celestarien
Copy link
Copy Markdown

In response to known vulnerabilities in SHA-1, including susceptibility to collision attacks, this update moves the hash function from SHA-1 to SHA-256. This change improves the overall security of the application by ensuring that the hashing algorithm is resistant to current cryptographic attacks.

In response to known vulnerabilities in SHA-1, including susceptibility to collision attacks, this update moves the hash function from SHA-1 to SHA-256. This change improves the overall security of the application by ensuring that the hashing algorithm is resistant to current cryptographic attacks.
@Vendicated
Copy link
Copy Markdown
Member

this change is not backwards compatible

@Vendicated
Copy link
Copy Markdown
Member

Vendicated commented Feb 18, 2024

i do agree that sha256 would be preferred, but at the same time it also doesn't matter much because the hash usage is not security critical. its purpose is just to improve privacy, by making it harder to figure out which settings belong to which user. there is not much point trying to attack the hash because you don't gain anything from knowing which user the settings belong to

since it's impossible to migrate an old database (because we have no way to retrieve the original values from the hash), this update would mean losing everyone's settings data.
thus, we can't make this change

thanks regardless

@Vendicated Vendicated closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants