feat(plugin): AllowedMentions#1998
Open
arHSM wants to merge 47 commits into
Open
Conversation
Signed-off-by: Han Seung Min - 한승민 <hanseungmin.ar@gmail.com>
Collaborator
|
I do wonder if this is actually safe to do for users since this is mainly a feature for bots, no? Just curious if this has the potential to flag. |
lewisakura
requested changes
Nov 28, 2023
Collaborator
lewisakura
left a comment
lewisakura
left a comment
There was a problem hiding this comment.
Plugin needs a README.md
…owed-mentions Signed-off-by: Han Seung Min - 한승민 <hanseungmin.ar@gmail.com>
lewisakura
requested changes
Nov 29, 2023
jamesbt365
reviewed
Oct 5, 2024
Contributor
There was a problem hiding this comment.
I can't seem to figure out why you can't toggle everyone mentions when you don't have the permission to do so in the guild but you do in the channel, but this change is requires as the roles field is not directly present when you use the getGuild method anymore.
| function getDisplayableRoleName(roleId: string, guildId: string | null) { | ||
| // You *can* mention roles in DMs but is it really worth adding the UI for | ||
| // it in DMs | ||
| const role = guildId ? Object.values(GuildStore.getGuild(guildId).roles).find(r => r.id === roleId)?.name : undefined; |
Contributor
There was a problem hiding this comment.
You need to do this now.
Suggested change
| const role = guildId ? Object.values(GuildStore.getGuild(guildId).roles).find(r => r.id === roleId)?.name : undefined; | |
| const role = guildId ? GuildStore.getRole(guildId, roleId)?.name : undefined; |
Contributor
|
Seems that some recent changes broke about half the patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllowedMentionsFine grained control over whom to ping when sending or editing a message.
PS: Editing
allowed_mentionsin a message requires changing the content as the API persists the mentions if content is not changed