Skip to content

feat(plugin): clock#2001

Closed
Tnixc wants to merge 4 commits into
Vendicated:mainfrom
Tnixc:main
Closed

feat(plugin): clock#2001
Tnixc wants to merge 4 commits into
Vendicated:mainfrom
Tnixc:main

Conversation

@Tnixc
Copy link
Copy Markdown

@Tnixc Tnixc commented Nov 18, 2023

Adds a customizable clock with timezones to the user panels section.
image

Comment thread src/plugins/Clock/index.ts Outdated
Comment thread src/plugins/Clock/index.ts Outdated
Comment thread src/plugins/Clock/index.ts Outdated
Tnixc and others added 3 commits November 18, 2023 18:55
Co-authored-by: MrDiamondDog <84212701+MrDiamondDog@users.noreply.github.com>
Co-authored-by: MrDiamondDog <84212701+MrDiamondDog@users.noreply.github.com>
@Vendicated
Copy link
Copy Markdown
Owner

sorry but this pr is very low quality, thus unmergeable

  • it has waaay too many / confusing settings
  • it uses dom manipulation instead of using react and patches
  • you're hardcoding css classes instead of obtaining them from webpack

@Tnixc
Copy link
Copy Markdown
Author

Tnixc commented Nov 19, 2023

Understandable

@Tnixc Tnixc closed this Nov 19, 2023
@Vendicated
Copy link
Copy Markdown
Owner

thank you for your effort anyway! you can still post it in the third party plugins channel if you want (although i still advise fixing these issues)

@Tnixc
Copy link
Copy Markdown
Author

Tnixc commented Nov 19, 2023

Of course, I'm not skilled enough to recognize its issues. I'll work this.

@Wannacry-ops
Copy link
Copy Markdown

¡Gracias por tu esfuerzo de todos modos! aún puedes publicarlo en el canal de complementos de terceros si lo deseas (aunque aún así recomiendo solucionar estos problemas)

what is that channel? can you send me the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants