Skip to content

Create MentionChannels#2172

Closed
cheesesamwich wants to merge 2 commits into
Vendicated:devfrom
cheesesamwich:MentionChannels
Closed

Create MentionChannels#2172
cheesesamwich wants to merge 2 commits into
Vendicated:devfrom
cheesesamwich:MentionChannels

Conversation

@cheesesamwich
Copy link
Copy Markdown
Contributor

@cheesesamwich cheesesamwich changed the base branch from main to dev February 13, 2024 17:13
@TheKodeToad
Copy link
Copy Markdown
Contributor

I think shift-clicking would be more useful (like with users)
Maybe the button should be renamed to Mention for consistency too

@cheesesamwich
Copy link
Copy Markdown
Contributor Author

Ill see if i can find a way to do shift clicking. Not exactly sure how though

@TheKodeToad
Copy link
Copy Markdown
Contributor

Take a look at the onclick handler for channel buttons maybe?

@cheesesamwich
Copy link
Copy Markdown
Contributor Author

Take a look at the onclick handler for channel buttons maybe?

yeah, i tried that but i couldnt find the react component. Gonna take a look again

@Vendicated
Copy link
Copy Markdown
Owner

I think shift-clicking would be more useful (like with users)

That sounds really good

@Vendicated
Copy link
Copy Markdown
Owner

yeah, i tried that but i couldnt find the react component. Gonna take a look again

react devtools are your friend.

Screencast.from.2024-02-15.09-40-32.webm

@cheesesamwich
Copy link
Copy Markdown
Contributor Author

react devtools are your friend.
i spent like a solid hour trying to do it and unfortunately i am unable to brain 💀

@Vendicated Vendicated marked this pull request as draft March 13, 2024 21:43
@cheesesamwich cheesesamwich closed this by deleting the head repository Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants