Skip to content

feat(plugin): CustomAppIcons#2252

Closed
SerStars wants to merge 2 commits into
Vendicated:mainfrom
SerStars:main
Closed

feat(plugin): CustomAppIcons#2252
SerStars wants to merge 2 commits into
Vendicated:mainfrom
SerStars:main

Conversation

@SerStars
Copy link
Copy Markdown
Contributor

Add/upload your own custom (In-)App Icon(s)

  • Following the steps in the plugin settings ("How to use?" header) should explain it all how you can use the plugin
ScreenShot1 ScreenShot2 ScreenShot3

@wavedevgit
Copy link
Copy Markdown
Contributor

Nice plugin (i contributed)

@TheKodeToad
Copy link
Copy Markdown
Contributor

Can't you do this with CS? is it particularly useful?

@wavedevgit
Copy link
Copy Markdown
Contributor

Can't you do this with CS? is it particularly useful?

You technically can use css, but this add's it to the menu, and css will break faster, because discord css classes names get's changed a lot

@Sqaaakoi
Copy link
Copy Markdown
Contributor

Yeah it can be done with CSS

At this point though we need a proper way of LOCALLY embedding images in custom quick css

@Sqaaakoi
Copy link
Copy Markdown
Contributor

Can't you do this with CS? is it particularly useful?

You technically can use css, but this add's it to the menu, and css will break faster, because discord css classes names get's changed a lot

This is why I believe a CSS postprocessor selector that effectively calls findByProps with all the arguments and returns the value of the first item with all spaces replaced with . so it's a class selector would be useful

@Vendicated
Copy link
Copy Markdown
Owner

to embed your image, encode it as data uri and use that. or upload it to imgur, github, or whatever else and link it

you can use attribute selectors instead of hardcoding class hashes. this way your css will only break if discord completely rewrites the ui

@wavedevgit
Copy link
Copy Markdown
Contributor

Yea

@wavedevgit
Copy link
Copy Markdown
Contributor

but this make's it easier instead of using css, because for some people they dont know how to write css

@Sqaaakoi
Copy link
Copy Markdown
Contributor

css is not that hard

also, the css snippets channel exists

@wavedevgit
Copy link
Copy Markdown
Contributor

Yea, but if you use css, it wont be easy to change the icons, this plugin saves the icons, so you can switch between them anytime

@TheKodeToad
Copy link
Copy Markdown
Contributor

Frequently switching between your own icons a very niche use-case

@nyakowint
Copy link
Copy Markdown
Contributor

nyakowint commented Mar 11, 2024

Vencord precedent/rule of thumb is to utilize css as opposed to plugins whenever possible, and like toad said switching between icons frequently enough to need this is pretty niche

@wavedevgit
Copy link
Copy Markdown
Contributor

but there is people that wont understand css, having a ui for this is much better & gives a better experience

@Vendicated
Copy link
Copy Markdown
Owner

if we went by the philosophy of "plugin is easier than css" then we'd have tons of plugins for everything and be extremely bloated

just write an easy to use snippet and tell people how to use it

if they can't figure it out, skill issue

@Vendicated Vendicated closed this Mar 11, 2024
@Vendicated
Copy link
Copy Markdown
Owner

just make it user friendly, like this. if someone cant figure that out they probably wouldnt be able to install vencord either

image

@wavedevgit
Copy link
Copy Markdown
Contributor

What about userbg plugin, it can be done using css right? why it got accepted? & what about fake profile themes plugin, it can be also done using css? why it got accepted???

Repository owner locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants