fix(PinDMs): display properly when there are 0 unpinned dms#2281
Merged
Conversation
also some small improvements
Collaborator
|
Can you also add a convertion from the old setting that sorted by last message? Currently it is needed to re-enable it manually |
…xv/Vencord into fix-pin-dms-and-improvments
Contributor
Author
|
done |
Nuckyz
requested changes
Mar 22, 2024
Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Owner
|
this still seems to rely on length. what happens if you use this on an account with 0 dms? |
…xv/Vencord into fix-pin-dms-and-improvments
Contributor
Author
|
i dont think we need to check if its initialized. Vencord/src/plugins/pinDms/index.tsx Lines 156 to 160 in ca18b6e Vencord/src/plugins/pinDms/data.ts Lines 35 to 40 in ca18b6e the init function forceUpdates the component on connection open (when channels have been fetched), meaning that check is kinda useless. |
Owner
|
thanks! |
lillithrosepup
pushed a commit
to lillithrosepup/Vencord
that referenced
this pull request
May 27, 2024
…ed#2281) Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com> Co-authored-by: V <vendicated@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you add all your dms to a category it causes everything to disappear. This happens because of this:
Vencord/src/plugins/pinDms/index.tsx
Line 203 in ca18b6e
this line of code assumes an empty
channelIdsmeans dms havent been fetched from discord, but it doenst account for the case where dms have been fetched and all the private dms have been added to one or more categories.