UserPlugins: Add clickable badges to external user plugins#238
Closed
lineargraph wants to merge 10 commits into
Closed
UserPlugins: Add clickable badges to external user plugins#238lineargraph wants to merge 10 commits into
lineargraph wants to merge 10 commits into
Conversation
lineargraph
force-pushed
the
feat/userpluginbadge
branch
2 times, most recently
from
fd29390 to
0966344
Compare
Contributor
Author
|
Also: After this we want to add dynamically loading plugins from URLs for user plugins, is there something for this already or can we go ahead with that. |
Owner
|
Loading plugins from urls isn't really possible because that means they are loaded too late. You need some way of obtaining them synchronously (e.g. save to file ahead of time and read with fs.readFileSync) |
Don't adding the new badge to all plugins as it is *theoretically* impossible for all of them to be new at once.
Contributor
Author
|
Yes, right now i allow downloading plugins to localstorage / datastorage and then force a CTRL+R reload. |
This patch adds a button to each user plugin (this is determined by the plugin directory). Additionally user plugins can specify an `externalLink` in their plugin definition to have their badge be clickable and link to an external website. Co-Authored-By: exhq <91651232+exhq@users.noreply.github.com>
lineargraph
force-pushed
the
feat/userpluginbadge
branch
from
0966344 to
7b5c8c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a button to each user plugin (this is determined by the
plugin directory). Additionally user plugins can specify an
externalLinkin their plugin definition to have their badge beclickable and link to an external website.
Note that this incorporates one file from #234 for the badge colors, but i can also just copy those styles over manually.