Skip to content

Fix Background Colour for Plugin Card & Settings#271

Closed
nmsturcke wants to merge 2 commits into
Vendicated:mainfrom
nmsturcke:fix-plugin-card-bg-color
Closed

Fix Background Colour for Plugin Card & Settings#271
nmsturcke wants to merge 2 commits into
Vendicated:mainfrom
nmsturcke:fix-plugin-card-bg-color

Conversation

@nmsturcke
Copy link
Copy Markdown
Contributor

Fix background colour for plugin card & settings when having a custom theme.

Before

image

image

After

image

image

@Vendicated
Copy link
Copy Markdown
Owner

are you sure this isn't just your theme being bad? it works fine for me and the card is consistent with that in the streamer mode settings page

@MeguminSama
Copy link
Copy Markdown
Contributor

I suggest you modify your theme to support the missing css variables. The variables used have been kept consistent with other settings pages.

@nmsturcke
Copy link
Copy Markdown
Contributor Author

are you sure this isn't just your theme being bad? it works fine for me and the card is consistent with that in the streamer mode settings page

I'm using Discord's theme experiment feature thing

@nmsturcke
Copy link
Copy Markdown
Contributor Author

image

this

@MeguminSama
Copy link
Copy Markdown
Contributor

MeguminSama commented Nov 28, 2022

The experiment is exactly that - an experiment. I doubt it's complete yet.

@nmsturcke
Copy link
Copy Markdown
Contributor Author

Okay, I'll close then ig.

@nmsturcke nmsturcke closed this Nov 28, 2022
@MeguminSama
Copy link
Copy Markdown
Contributor

Thank you though, will keep this in mind to test once/if Discord chooses to release this feature.

@Vendicated
Copy link
Copy Markdown
Owner

it works as expected for me, even with the experiment. the dono and button cards are themed correctly and the plugin cards while being ugly are themed the same as the highlight which is the expected behaviour
image
image

@nmsturcke
Copy link
Copy Markdown
Contributor Author

it works as expected for me, even with the experiment. the dono and button cards are themed correctly and the plugin cards while being ugly are themed the same as the highlight which is the expected behaviour image image

Not for me 🤷
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants