Add plugin toggling to venbot embeds#2732
Conversation
fa092cf to
eb63a54
Compare
|
after a tiny bit of extra thinking, why not just delete the original embed and replace it with a PluginCard using MessageAccessoriesAPI |
|
looking into this |
|
this is really cool, never thought about doing something like this when i wrote the original feature for the exclusion stuff, i think it would be best to just render a plugin card but then replace the switch with a yellow exclamation icon (like what discord uses) with a tooltip that explains why, it'd require modification of the plugin card to support this though |
Sqaaakoi
left a comment
There was a problem hiding this comment.
I feel like you've oversimplified what code I gave you earlier in order to not duplicate things and to make it easier to understand, rather than keeping consistency with how PluginCard is wrapped in PluginSettings
Additionally I have some concerns about how URLs aren't being used to get the plugin name
Sqaaakoi
left a comment
There was a problem hiding this comment.
I love it so far! I still feel there are a few more details that need to be added/tweaked
|
maybe instead of completely replacing the original message, we could instead add the plugin card as Accessory? So the message will have both please also resolve conflicts 🙏🏻 |
|
I'm gonna rework how plugin cards look soon with components v2 let's wait for that and make these buttons look less crap then (not the ugly blue buttons) |
|
I'm not really a fan of all these changes to the settings. the code should for the most part be only in the plugin file, settings shouldn't have to know about any of this |
|
reverted those changes |




Discord_pftXYSe25P.mp4