Skip to content

Add Firefox extension build#277

Merged
Vendicated merged 7 commits into
Vendicated:mainfrom
lineargraph:feat/manifestv2
Dec 1, 2022
Merged

Add Firefox extension build#277
Vendicated merged 7 commits into
Vendicated:mainfrom
lineargraph:feat/manifestv2

Conversation

@lineargraph
Copy link
Copy Markdown
Contributor

@lineargraph lineargraph commented Dec 1, 2022

Because there are so few differences between manifest v2 and v3 aside
from header rewriting i just wrote two different manifests. We also generate a .xpi file that gets added to the nightly releases on main pushes. I am aware of #69, however that PR does not support manifest v2 (yet?), and it is still a few months till firefox releases manifest v3, so I think until then this would be a worthwhile effort to maintain.

@lineargraph
Add Manifest V2 support
05fe47d 
Because there are so few differences between manifest v2 and v3 aside
from header rewriting i just wrote two different manifests. Right now
this only works on firefox with unpacked extensions.
@lineargraph lineargraph changed the title Add Manifest V2 support Add Manifest V2 (Firefox) support Dec 1, 2022
@lineargraph
Copy link
Copy Markdown
Contributor Author

lineargraph commented Dec 1, 2022 •
edited
Loading

This needs setting WEBEXT_USER and WEBEXT_SECRET as repository github action secrets from https://addons.mozilla.org/en-US/developers/addon/api/key in order to work with the signed releases

Vendicated
Vendicated reviewed Dec 1, 2022
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
@lineargraph
Rename packaged extensions in releases
ac1bbf5 
Packaged extensions now reflect their target browser name instead of
just manifest versions.
@lineargraph
Fix ESLint on browser background script
601ebee
@lineargraph
Update README to point to new plugin links
6ea4acb
Vendicated
Vendicated reviewed Dec 1, 2022
View reviewed changes
Comment thread browser/background.js
Vendicated
Vendicated reviewed Dec 1, 2022
View reviewed changes
Comment thread browser/background.js Outdated
Vendicated
Vendicated reviewed Dec 1, 2022
View reviewed changes
Comment thread browser/manifestv2.json
"background.js"
]
}
}
Copy link
Copy Markdown
Owner

@Vendicated Vendicated Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this manifest missing the gecko specific id to even be accepted by web-ext?

@Vendicated Vendicated changed the title Add Manifest V2 (Firefox) support Add Firefox extension build Dec 1, 2022
@Vendicated Vendicated merged commit 0ff6d3d into Vendicated:main Dec 1, 2022
@Vendicated Vendicated mentioned this pull request Dec 1, 2022
Closed
@lineargraph lineargraph deleted the feat/manifestv2 branch December 2, 2022 09:46
Vap0r1ze added a commit to Vap0r1ze/Vencord that referenced this pull request Dec 23, 2022
@Vap0r1ze
Squashed commit of the following:
6b415f3 
commit 2172cae
Author: Dominik <dominik.buettner1711@gmail.com>
Date:   Fri Dec 23 04:16:17 2022 +0100

    [PlatformIndicators] Add own Status (Vendicated#350)

    Co-authored-by: Dominik <domi@bambus.me>
    Co-authored-by: HypedDomi <HypedDomi@users.noreply.github.com>
    Co-authored-by: Ven <vendicated@riseup.net>

commit e740f55
Author: Ven <vendicated@riseup.net>
Date:   Fri Dec 23 03:46:39 2022 +0100

    Fix Vencord

commit aff1b68
Author: Nickyux <30734036+nmsturcke@users.noreply.github.com>
Date:   Fri Dec 23 03:17:19 2022 +0100

    Add a "NEW" Badge for New Plugins (V2)! (Vendicated#234)

    Co-authored-by: Ven <vendicated@riseup.net>
    Co-authored-by: Justice Almanzar <superdash993@gmail.com>
    Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>

commit 074542f
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Thu Dec 22 23:00:59 2022 -0300

    feat(plugins): NoScreensharePreview plugin (Vendicated#358)

commit b0c41d5
Author: Vendicated <vendicated@riseup.net>
Date:   Thu Dec 22 18:04:37 2022 +0100

    Improve treeshaking

commit af0d34b
Author: Elliott Tallis <tallis.elliott@gmail.com>
Date:   Thu Dec 22 16:42:54 2022 +0000

    pointy is a "contributor" (Vendicated#359)

commit 6dd705f
Author: Ven <vendicated@riseup.net>
Date:   Thu Dec 22 17:25:57 2022 +0100

    Update build.yml

commit 259f028
Author: Ven <vendicated@riseup.net>
Date:   Wed Dec 21 22:43:54 2022 +0100

    Update build.yml

commit cb9eb1f
Author: Ven <vendicated@riseup.net>
Date:   Wed Dec 21 21:12:28 2022 +0100

    i hate ci i hate ci

commit 42b4eeb
Author: Ven <vendicated@riseup.net>
Date:   Wed Dec 21 21:05:52 2022 +0100

    Update build.yml

commit a9ee0c7
Author: Ven <vendicated@riseup.net>
Date:   Wed Dec 21 20:59:06 2022 +0100

    Delete obsolete FUNDING.yml

commit 73b7f11
Author: Elliott Tallis <tallis.elliott@gmail.com>
Date:   Wed Dec 21 19:58:07 2022 +0000

    Also push builds to https://github.com/Vencord/builds (Vendicated#344)

    Co-authored-by: Ven <vendicated@riseup.net>

commit d806be1
Author: ActuallyTheSun <78964224+ActuallyTheSun@users.noreply.github.com>
Date:   Wed Dec 21 21:16:32 2022 +0200

    feat(PlatformIndicators): add indicator to messages (Vendicated#343)

commit 1f73cfa
Author: V3L0C1T13S <51764975+V3L0C1T13S@users.noreply.github.com>
Date:   Wed Dec 21 10:12:05 2022 -0500

    EmoteCloner: Use CDN_HOST variable to support unofficial backends (Vendicated#356)

commit 7e60773
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Tue Dec 20 19:54:47 2022 -0300

    feat(plugins): DisableDMCallIdle (Vendicated#355)

commit 103c499
Author: Vendicated <vendicated@riseup.net>
Date:   Tue Dec 20 17:43:55 2022 +0100

    Monaco Popup: Add metadata, store window instance

commit 9dcafbf
Author: Vendicated <vendicated@riseup.net>
Date:   Tue Dec 20 18:03:58 2022 +0100

    Fix Notices

    Have I ever mentioned how terrible Discord's Notices code is?

commit 1742bb6
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Tue Dec 20 12:18:15 2022 -0300

    Fix StartupTimings (Vendicated#353)

commit 0743c12
Author: Vendicated <vendicated@riseup.net>
Date:   Tue Dec 20 02:59:16 2022 +0100

    Add canary test

commit 94ad8e8
Author: Vendicated <vendicated@riseup.net>
Date:   Tue Dec 20 00:33:52 2022 +0100

    Add useEffect/useState/useMemo to webpack commons

commit 989bd36
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Mon Dec 19 17:59:54 2022 -0500

    refactor: identifier escapes + "self" group (Vendicated#339)

    Co-authored-by: Ven <vendicated@riseup.net>

commit 4974c53
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Sun Dec 18 01:13:34 2022 -0300

    Improve PronounDB patch (Vendicated#348)

commit 47de9fa
Author: Manti <67705577+mantikafasi@users.noreply.github.com>
Date:   Sun Dec 18 01:30:29 2022 +0300

    Make some changes to reviewdb ui and add badges to it (Vendicated#245)

commit 3efc792
Author: Nico <nico@d3sox.me>
Date:   Fri Dec 16 15:51:23 2022 +0100

    [ShowHiddenChannels] Fix last message date (Vendicated#342)

commit 4561642
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Fri Dec 16 10:16:47 2022 -0300

    fix(MessageLogger): Fix module not being found (Vendicated#338)

commit c257f86
Author: Vendicated <vendicated@riseup.net>
Date:   Thu Dec 15 17:52:54 2022 +0100

    Fix experiments

commit f6122a0
Author: Pedro <nekkan@protonmail.ch>
Date:   Thu Dec 15 11:05:44 2022 -0300

    feat(NoReplyMention): exempt list support (Vendicated#337)

commit f1bdfdd
Author: Ven <vendicated@riseup.net>
Date:   Wed Dec 14 23:50:00 2022 +0100

    Update nsfwGateBypass.ts

commit c8f2141
Author: ActuallyTheSun <78964224+ActuallyTheSun@users.noreply.github.com>
Date:   Thu Dec 15 00:44:58 2022 +0200

    feat(plugin): add MessageLinkEmbeds (Vendicated#264)

    Co-authored-by: Ven <vendicated@riseup.net>

commit fea8c60
Author: megumin <megumin.bakaretsurie@gmail.com>
Date:   Wed Dec 14 22:35:02 2022 +0000

    hotfix injector for ptb/canary/dev (Vendicated#330)

commit a67db11
Author: A user <pedro.santos.cartaxo@gmail.com>
Date:   Tue Dec 13 20:44:57 2022 -0300

    Improve Settings UI & View Raw Modal (Vendicated#332)

    very cool

commit 9a088b7
Author: Box_ <70744994+Default-Box@users.noreply.github.com>
Date:   Sat Dec 10 08:54:46 2022 +1100

    MoreKaomoji: Add more kaomoji (Vendicated#299)

commit ebb8da0
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Thu Dec 8 22:32:16 2022 -0500

    fix(FakeNitro): more reliable patches (Vendicated#304)

commit f2e0542
Author: Commandtechno <68407783+Commandtechno@users.noreply.github.com>
Date:   Thu Dec 8 17:35:09 2022 -0600

    New Plugin: NSFWGateBypass (Vendicated#300)

commit ee24439
Author: megumin <megumin.bakaretsurie@gmail.com>
Date:   Thu Dec 8 22:53:12 2022 +0000

    feat(plugin): sort friend requests by date received (Vendicated#280)

commit 022bf17
Author: David Ralph <ohlookitsderpy@protonmail.com>
Date:   Thu Dec 8 22:51:18 2022 +0000

    fix inconsistent margins & capitalisation (Vendicated#281)

commit 2de4619
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Thu Dec 8 09:54:19 2022 -0500

    fix(ShikiCodeblocks): spoilers (Vendicated#298)

    * fix(ShikiCodeblocks): spoilers

    * fix a settings bug i thikn

commit 2d08dd8
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Wed Dec 7 09:33:40 2022 -0500

    Shiki settings preview (Vendicated#297)

commit 49b45d8
Author: Commandtechno <68407783+Commandtechno@users.noreply.github.com>
Date:   Mon Dec 5 17:14:48 2022 -0600

    google changed their shit (Vendicated#294)

commit 8a5a5c7
Author: Cloudburst <18114966+C10udburst@users.noreply.github.com>
Date:   Sun Dec 4 13:58:29 2022 +0100

    UserScript: add csp bypassing fetch (Vendicated#284)

commit 53d0a55
Author: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Date:   Sat Dec 3 22:16:47 2022 -0300

    refactor(IgnoreActivities): Use React Components and support Embedded Activities (Vendicated#282)

commit 25ef5d6
Author: Commandtechno <68407783+Commandtechno@users.noreply.github.com>
Date:   Sat Dec 3 16:42:18 2022 -0600

    add me to contributors (Vendicated#287)

commit c74241f
Author: Commandtechno <68407783+Commandtechno@users.noreply.github.com>
Date:   Sat Dec 3 16:11:08 2022 -0600

    add commas in member count (Vendicated#286)

    l

commit 4d8145f
Author: Vendicated <vendicated@riseup.net>
Date:   Sat Dec 3 14:57:51 2022 +0100

    Fix arrpc

commit d4f7021
Author: Ven <vendicated@riseup.net>
Date:   Sat Dec 3 13:42:46 2022 +0100

    ci: Do not release extension-v2.zip

commit 6b4b477
Author: Ven <vendicated@riseup.net>
Date:   Sat Dec 3 13:41:31 2022 +0100

    Update README.md

commit 54010aa
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Sat Dec 3 05:32:14 2022 -0500

    fix: hljs fallback (Vendicated#283)

commit 62b2ace
Author: A user <pedro.santos.cartaxo@gmail.com>
Date:   Fri Dec 2 12:55:53 2022 -0300

    Add support for Flatpak for Git updating (Vendicated#274)

    Co-authored-by: Ven <vendicated@riseup.net>

commit 41dddc9
Author: Justice Almanzar <superdash993@gmail.com>
Date:   Fri Dec 2 10:43:37 2022 -0500

    feat(plugin): ShikiCodeblocks (Vendicated#267)

    Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>
    Co-authored-by: Ven <vendicated@riseup.net>

commit 4760af7
Author: 12944qwerty <qwerty12944qwerty@gmail.com>
Date:   Fri Dec 2 09:38:52 2022 -0600

    add ViewRaw plugin & MiniPopover API (Vendicated#275)

    Co-authored-by: Vendicated <vendicated@riseup.net>

commit 06d32ae
Author: Vendicated <vendicated@riseup.net>
Date:   Fri Dec 2 14:24:23 2022 +0100

    browser: remove firefox extension id

commit 2564ab7
Author: Vendicated <vendicated@riseup.net>
Date:   Fri Dec 2 14:21:44 2022 +0100

    ci: unlisted firefox builds for now

commit 5e97cc0
Author: Vendicated <vendicated@riseup.net>
Date:   Fri Dec 2 14:11:20 2022 +0100

    QuickCss: Hide MenuBar; explicitly enable contextIsolation

    Closes Vendicated#260

commit b9e9d9b
Author: Vendicated <vendicated@riseup.net>
Date:   Fri Dec 2 14:10:40 2022 +0100

    Add --vanilla flag, strip csp on mainFrame only

commit daf3a1d
Author: Vendicated <vendicated@riseup.net>
Date:   Thu Dec 1 19:43:49 2022 +0100

    Try to make firefox publish work

commit f1fb79d
Author: Ven <vendicated@riseup.net>
Date:   Thu Dec 1 19:22:49 2022 +0100

    Fix workflow

commit 0ff6d3d
Author: Roman / Linnea Gräf <romangraef@gmail.com>
Date:   Thu Dec 1 19:16:09 2022 +0100

    Add Firefox extension build (Vendicated#277)

commit 734054f
Author: Vendicated <vendicated@riseup.net>
Date:   Thu Dec 1 03:38:17 2022 +0100

    feat(Settings): Allow moving Vencord section to different places

commit f94cbfb
Author: Vendicated <vendicated@riseup.net>
Date:   Thu Dec 1 03:01:44 2022 +0100

    Add basic themes tab

commit fc09460
Author: Sofia <me@dzshn.xyz>
Date:   Mon Nov 28 23:25:07 2022 +0000

    feat(plugin): add ServerListIndicators (Vendicated#272)

commit e884738
Author: Vendicated <vendicated@riseup.net>
Date:   Mon Nov 28 23:01:04 2022 +0100

    MemberCount: Fix misleading count, add tooltip

commit c583bad
Author: megumin <megumin.bakaretsurie@gmail.com>
Date:   Mon Nov 28 18:59:42 2022 +0000

    the shiggy wiggy (Vendicated#270)

commit 36b7878
Author: Vendicated <vendicated@riseup.net>
Date:   Mon Nov 28 19:29:46 2022 +0100

    Add MemberCount plugin
CodeF53 pushed a commit to CodeF53/Vencord that referenced this pull request Nov 16, 2025
@davidkra230 @thororen1234
create the StreamingCodecDisabler plugin (Vendicated#277)
8162a62 
* create StreamingCodecDisabler

* fixes

* fix typo for av1

* Fixes

---------

Co-authored-by: thororen1234 <78185467+thororen1234@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vendicated Vendicated Vendicated left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lineargraph @Vendicated