MentionAvatars: add more options and new role default icon#2823
Open
sadan4 wants to merge 9 commits into
Open
Conversation
sadan4
force-pushed
the
fix-showRoleIcons
branch
from
a33ede4 to
d0dbe5f
Compare
Owner
|
is this still needed? |
Contributor
Author
|
yeah, ill clean it up soon:tm: |
Vendicated
reviewed
Sep 4, 2025
Vendicated
reviewed
Sep 4, 2025
Owner
Vendicated
left a comment
Vendicated
left a comment
There was a problem hiding this comment.
Besides this feedback, the settings order is so derpy
it should be in this order:
- Show @
- Enable for Users
- Enable for Roles
- Show Role default icon
Vendicated
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed some things with the plugin
you had to have both on, or none
the avatar was not replacing the icon
you could not turn the default avatar off