Skip to content

ReplaceAnything plugin#3340

Closed
zoinbase wants to merge 2 commits into
Vendicated:mainfrom
zoinbase:main
Closed

ReplaceAnything plugin#3340
zoinbase wants to merge 2 commits into
Vendicated:mainfrom
zoinbase:main

Conversation

@zoinbase
Copy link
Copy Markdown

@zoinbase zoinbase commented Apr 1, 2025

This plugin allows users to replace any specified text with another chosen text before sending a message.

@jamesbt365
Copy link
Copy Markdown
Contributor

  1. you don't need to reopen your PR to push new commits
  2. you have just reinvented TextReplace, but made it a lot worse

@zoinbase
Copy link
Copy Markdown
Author

zoinbase commented Apr 1, 2025

I didnt know about TextReplace but i just went thru it and it’s kinda overcomplicated. It has regex support, multiple rule types, and a bunch of UI elements that most people don’t need. Mine is way simpler, just pick what you want to replace and what to replace it with, and you’re done. No unnecessary settings, no clutter, just works.

@lolsuffocate
Copy link
Copy Markdown
Contributor

You still have to go to the settings modal and set the text for yours too, which is exactly the same as if you just put a single rule into TextReplace, it just allows you to add more than one

@jamesbt365
Copy link
Copy Markdown
Contributor

and it’s kinda overcomplicated

It really isn't that complicated, you get your find, your replace and an option to only replace in certain situations

and a bunch of UI elements that most people don’t need

I don't get this at all? What?

Mine is way simpler

Yes, it is simpler but in a way that makes this unusable for any person who wants to replace multiple things or more advanced things, your plugin has 1 replacement option, thats it, you can only have 1, TextReplace lets you have as many as you want, which is great because most people will want to replace more than one thing.

Absolutely nothing is unnecessary about TextReplace and your plugin doesn't improve on anything at all, it is just way more expansive and provides way more usability than this plugin of yours ever does.

Vencord is not a fan of implementing duplicate functionality, and this just lacks code quality and usability in comparison to every other plugin in this client mod.

(also, you build your regex you use the replace the text every time somebody sends a message including the target, which is just inefficient and completely unnecessary as you can do string replacements without regex)

This just lacks usability and quality, you can't argue TextReplace is overcomplicated here.

I'm all for improvements to Vencord, but this just isn't it.

@zoinbase zoinbase closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants