feat(Plugin): InvisibleChat#349
Merged
Merged
Conversation
Vendicated
reviewed
Dec 19, 2022
Co-authored-by: Ven <vendicated@riseup.net>
Owner
|
Using divs with hardcoded colour for text is a bad idea, because it means zero theme support and might even look terrible on stock light theme. Please use Form components (Forms.FormText, Forms.FormDivider, etc) instead |
Owner
|
the library is also pretty big so it'd be good to fetch it on demand from a cdn like unpkg or cdnjs |
Contributor
Author
|
you will merge |
Contributor
Author
|
now you will merge |
Contributor
:husk: |
SammCheese
requested review from
ArjixWasTaken and
Vendicated
and removed request for
ArjixWasTaken and
Vendicated
Contributor
Author
|
Bruh GitHub Mobile is horrid |
SammCheese
requested review from
Vendicated
and removed request for
ArjixWasTaken
Contributor
Author
|
VEN |
Contributor
|
instead of merging upstream changes, I'd suggest rebasing |
Contributor
Author
|
How why |
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Vendicated
reviewed
Dec 23, 2022
Contributor
Author
|
@Vendicated venven |
Contributor
|
ven will not merge |
Contributor
Author
|
WAAAAA |
Contributor
Author
|
@Vendicated it's been 10 days. |
Contributor
|
We are doomed, we should vote for megu to be in charge. |
Contributor
Author
|
Actually Agreed |
Vendicated
approved these changes
Jan 7, 2023
Owner
Vendicated
left a comment
Vendicated
left a comment
There was a problem hiding this comment.
Okay looks good from my side now, but I did a bunch of changes so please see if you still like everything
EtorixDev
added a commit
to EtorixDev/Vencord
that referenced
this pull request
Aug 20, 2025
* PR. * Update definitions.tsx * Typo + cleanup. * Revert breaking change. * Fix image extension flaw + embed context flaw. * Fix typo. * Label. * Video + label fixes. * Label improvement. * Content type improvements. --------- Co-authored-by: thororen <78185467+thororen1234@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of Invisible Chat for Vencord.
Features and Design are kept to a minimum for now.