Skip to content

feat(Plugin): LurkGuild#429

Closed
s809 wants to merge 11 commits into
Vendicated:mainfrom
s809:main
Closed

feat(Plugin): LurkGuild#429
s809 wants to merge 11 commits into
Vendicated:mainfrom
s809:main

Conversation

@s809
Copy link
Copy Markdown

@s809 s809 commented Jan 18, 2023

Allows to preview public guilds from invite

@s809 s809 changed the title Add LurkGuild feat(Plugin): LurkGuild Jan 18, 2023
@Vendicated
Copy link
Copy Markdown
Owner

isn't this already a default feature? I'm also really worried about joining guilds via plugins since it's very easy to get banned

@s809
Copy link
Copy Markdown
Author

s809 commented Jan 19, 2023

It's built into discovery, and it's same as searching a server there and clicking on it (except some analytics will be missing obv). So as long as you don't spam it i think it should be good

@Vendicated
Copy link
Copy Markdown
Owner

Please add all the analytics parameters

@ArjixWasTaken
Copy link
Copy Markdown
Contributor

ArjixWasTaken commented Jan 19, 2023

Please add all the analytics parameters

Don't we already block all analytics?
Nvm, this is not going to the science endpoint

Comment thread src/plugins/lurkGuild.tsx Outdated
Comment thread src/plugins/lurkGuild.tsx Outdated
Comment thread src/plugins/lurkGuild.tsx Outdated
Comment thread src/plugins/lurkGuild.tsx Outdated
find: ".GuildSplash,{",
replacement: {
match: /(Messages\.JOINED_GUILD:[a-zA-Z.]+?\.Messages\.JOIN_GUILD}\))/,
replace: "$1,$self.render()"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using the context variable, doesn't this patch have access to the guild object? If so, you should pass it as prop, global variables should be a last resort

@s809 s809 closed this Feb 4, 2023
EtorixDev pushed a commit to EtorixDev/Vencord that referenced this pull request Oct 1, 2025
* move globalbadges api

* Update API URL for badge images

* bleh

* bleh

* bleh: the reckoning

* bleh: the final remorse

---------

Co-authored-by: thororen1234 <78185467+thororen1234@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants