[Feat] [Studio]: Add interactive GitHub links to brand asset cards#63
Conversation
Gautam25Raj
left a comment
There was a problem hiding this comment.
Hi @d3vpool, thanks for taking the initiative to submit this PR!
Before we can merge this, we have a few guidelines and feedback we'd like you to address:
-
Contribution Workflow: For future issues, please comment on the issue first to discuss it and get assigned before starting work. This helps our team coordinate and avoids duplicate efforts among contributors.
-
Use Next.js
<Link>: Please use Next.js's<Link>component (imported from"next/link") instead of the standard HTML<a>tags. This ensures consistent navigation behavior and conforms to the project's codebase standards. -
Missing Hover Interactions: The cards are wrapped in links but don't change visual state on hover. Adding transition effects and subtle hover backgrounds (e.g., hover:bg-muted/10 or changing text colors on hover) will make the cards feel truly interactive.
-
Code Formatting & Linting: It looks like some of the code is unformatted. Please run the following commands in the root of the project to clean it up before updating the PR:
npm run format:write npm run lint
-
Accessibility (a11y) Gaps:
- The
ExternalLinkicon needsaria-hidden="true"so screen readers don't try to announce it.
- The
|
Thanks for the review and for applying the suggested fixes. Really appreciate the guidance! |
Summary
Testing
/style-guideCloses #60