Skip to content

[Feat] [Studio]: Add interactive GitHub links to brand asset cards#63

Merged
Gautam25Raj merged 2 commits into
VeriWorkly:masterfrom
d3vpool:feat/style-guide-links
May 21, 2026
Merged

[Feat] [Studio]: Add interactive GitHub links to brand asset cards#63
Gautam25Raj merged 2 commits into
VeriWorkly:masterfrom
d3vpool:feat/style-guide-links

Conversation

@d3vpool
Copy link
Copy Markdown
Contributor

@d3vpool d3vpool commented May 20, 2026

Summary

  • Made the Logo Path card clickable with a GitHub link
  • Made the Design References card clickable with a GitHub link
  • Added external link icons using lucide-react

Testing

  • Verified links open correctly
  • Tested locally on /style-guide
  • Ran lint and formatting checks

Closes #60

Copy link
Copy Markdown
Collaborator

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @d3vpool, thanks for taking the initiative to submit this PR!

Before we can merge this, we have a few guidelines and feedback we'd like you to address:

  1. Contribution Workflow: For future issues, please comment on the issue first to discuss it and get assigned before starting work. This helps our team coordinate and avoids duplicate efforts among contributors.

  2. Use Next.js <Link>: Please use Next.js's <Link> component (imported from "next/link") instead of the standard HTML <a> tags. This ensures consistent navigation behavior and conforms to the project's codebase standards.

  3. Missing Hover Interactions: The cards are wrapped in links but don't change visual state on hover. Adding transition effects and subtle hover backgrounds (e.g., hover:bg-muted/10 or changing text colors on hover) will make the cards feel truly interactive.

  4. Code Formatting & Linting: It looks like some of the code is unformatted. Please run the following commands in the root of the project to clean it up before updating the PR:

    npm run format:write
    npm run lint
    
  5. Accessibility (a11y) Gaps:

    • The ExternalLink icon needs aria-hidden="true" so screen readers don't try to announce it.

Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx
Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx
Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx
Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx Outdated
Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx Outdated
Comment thread apps/site/app/style-guide/_components/BrandAssetsSection.tsx Outdated
@Gautam25Raj Gautam25Raj added enhancement New feature or request frontend UI/client-side code ui/ux Design or user experience improvements labels May 21, 2026
@Gautam25Raj Gautam25Raj changed the title feat: add interactive GitHub links to brand asset cards [Feat] [Studio]: Add interactive GitHub links to brand asset cards May 21, 2026
@Gautam25Raj Gautam25Raj merged commit 43a9f6d into VeriWorkly:master May 21, 2026
@d3vpool
Copy link
Copy Markdown
Contributor Author

d3vpool commented May 21, 2026

Thanks for the review and for applying the suggested fixes. Really appreciate the guidance!

@d3vpool d3vpool deleted the feat/style-guide-links branch May 21, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend UI/client-side code ui/ux Design or user experience improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make Style-Guide Brand Assets interactive (GitHub links & download)

2 participants