Conversation
The block_buffer can hold a full block (64 bytes) when splitIntoBlockWords keeps exactly 64 bytes as remainder instead of processing them.
- Add ByteOrTable lookup table for byte-wise OR verification - Implement Or32 circuit following the same pattern as Xor32 - Add or_mul_two_pow and or_sum lemmas to Bitwise.lean - Prove soundness and completeness theorems for Or32 The Or32 gadget will be used in BLAKE3's finalizeChunk for combining flags.
- Add spaces before colons in type annotations (x : Type) - Remove spaces in polynomial multiplication (x*256 not x * 256) - Remove spaces in angle brackets destructuring patterns
… into blake3-finalize-chunk
Remove spaces around * in polynomial expressions to follow local conventions in doc/conventions.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mitschabaude
approved these changes
Sep 4, 2025
Collaborator
mitschabaude
left a comment
mitschabaude
left a comment
There was a problem hiding this comment.
💪🏻
just a few comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements and verifies a circuit for
finalizeChunkfunction in the BLAKE3 spec.This is a part of #250.