Skip to content

better error handling when accepting or discarding files #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
May 13, 2022
Merged

better error handling when accepting or discarding files #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/DiffEngineTray/FileEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ public static void SafeDelete(string path)
//Swallow this since it is likely that a running test it reading or
//writing to the files, and the result will re-add the tracked item
}
catch (Exception exception)
{
ExceptionHandler.Handle($"Filed to delete '{path}'.", exception);
}
}

public static void SafeMove(string temp, string target)
Expand All @@ -38,5 +42,9 @@ public static void SafeMove(string temp, string target)
//Swallow this since it is likely that a running test it reading or
//writing to the files, and the result will re-add the tracked item
}
catch (Exception exception)
{
ExceptionHandler.Handle($"Filed to move '{temp}' to '{target}'.", exception);
}
}
}