fix: 🐛 improve password confirmation prompt (fixes #1390)#1418
Merged
fix: 🐛 improve password confirmation prompt (fixes #1390)#1418
Conversation
srizzling
changed the title
pwmcintyre
reviewed
Mar 24, 2025
ary-b
reviewed
Apr 3, 2025
ary-b
left a comment
ary-b
left a comment
There was a problem hiding this comment.
Thanks a lot for taking the time to look into this team, I really appreciate it 😄 I agree that the password repeater could be removed, but not a big deal if it stays with the enhanced prompts. Cheers everyone!
Prior to this commit, the configure flow contained multiple if statements, making the logic unnecessarily complex. Additionally, the password repeater was included, which is not required as this process is not a sign-up flow. The password repeater also caused ambiguity when passwords did not match. After this commit, The configure flow has been simplified by reducing the number of if statements, making the logic more straightforward. The password repeater has been removed entirely, as it is not needed. If the user inputs the wrong password, they can simply re-initiate the configure process. fixes #1390 Signed-off-by: Sriram Venkatesh <sriram.venkatesh@versent.com.au>
Prior to this commit, The `console.go` file contained a duplicate error check for the `err` variable, which was redundant and unnecessary. After this commit, The duplicate error check has been removed, simplifying the code and improving readability. Signed-off-by: Sriram Venkatesh <sriram.venkatesh@versent.com.au>
srizzling
force-pushed
the
fix-ambigous-errors
branch
from
51dae7b to
0501c88
Compare
RossRichardson
approved these changes
Apr 30, 2025
RossRichardson
left a comment
RossRichardson
left a comment
There was a problem hiding this comment.
LGTM.
Acknowledging Password prompt now changed to Enter Password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change:
After this change:
fixes #1390