Conversation
--try-no-prompt uses credentials from non-interactive sources, if possilbe. Otherwise it prompts the user to enter these credentials.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1428 +/- ##
===========================================
- Coverage 42.19% 28.13% -14.06%
===========================================
Files 54 70 +16
Lines 6456 12543 +6087
===========================================
+ Hits 2724 3529 +805
- Misses 3283 8538 +5255
- Partials 449 476 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@xenia-lang Massive thanks for working on this. I have tested locally and can confirm it is working as expected, and I'm looking forward to using this. |
|
Very happy to get this merged. Since I am also really looking forward to it, I'd like to ask: When is the next release planned? To be clear, I'm not trying to be pushy. I'd just like to get an idea of how long we need to wait before we can use this. |
--try-no-promptuses credentials from non-interactive sources, if possilbe.Otherwise it prompts the user to enter these credentials.This optimizes the workflow by eliminating the need to press enter when valid credentials are present, while allowing to have them added to the keyring without the need to rerun the command (as would be necessary with
--no-prompt).--no-promptis still available for non-interactive usecases (see discussion in #101). This also creates an obvious place in the interface to add the functionality discussed in #101.Naming of the new flag is open for discussion. Its placement (
loginFlagsvscommonFlags) is as well.Unfortunately, I do not have an overview over all the use cases for saml2aws. If these changes hinder any use case, guidance is much appreciated. Same goes for general use of the Go language.