Skip to content

Add --try-no-prompt flag#1428

Merged
tinaboyce merged 2 commits intoVersent:masterfrom
xenia-lang:master
May 13, 2025
Merged

Add --try-no-prompt flag#1428
tinaboyce merged 2 commits intoVersent:masterfrom
xenia-lang:master

Conversation

@xenia-lang
Copy link
Contributor

@xenia-lang xenia-lang commented Mar 28, 2025

--try-no-prompt uses credentials from non-interactive sources, if possilbe.Otherwise it prompts the user to enter these credentials.

This optimizes the workflow by eliminating the need to press enter when valid credentials are present, while allowing to have them added to the keyring without the need to rerun the command (as would be necessary with --no-prompt). --no-prompt is still available for non-interactive usecases (see discussion in #101). This also creates an obvious place in the interface to add the functionality discussed in #101.

Naming of the new flag is open for discussion. Its placement (loginFlags vs commonFlags) is as well.

Unfortunately, I do not have an overview over all the use cases for saml2aws. If these changes hinder any use case, guidance is much appreciated. Same goes for general use of the Go language.

--try-no-prompt uses credentials from non-interactive sources, if
possilbe. Otherwise it prompts the user to enter these
credentials.
@xenia-lang xenia-lang marked this pull request as ready for review March 28, 2025 17:36
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.13%. Comparing base (99d6fe4) to head (0625a7b).
Report is 155 commits behind head on master.

Files with missing lines Patch % Lines
cmd/saml2aws/commands/login.go 0.00% 3 Missing ⚠️
cmd/saml2aws/main.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1428       +/-   ##
===========================================
- Coverage   42.19%   28.13%   -14.06%     
===========================================
  Files          54       70       +16     
  Lines        6456    12543     +6087     
===========================================
+ Hits         2724     3529      +805     
- Misses       3283     8538     +5255     
- Partials      449      476       +27     
Flag Coverage Δ
unittests 28.13% <0.00%> (-14.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tinaboyce
Copy link
Contributor

@xenia-lang Massive thanks for working on this. I have tested locally and can confirm it is working as expected, and I'm looking forward to using this.

@tinaboyce tinaboyce merged commit 65195ee into Versent:master May 13, 2025
12 checks passed
@xenia-lang
Copy link
Contributor Author

Very happy to get this merged. Since I am also really looking forward to it, I'd like to ask: When is the next release planned?

To be clear, I'm not trying to be pushy. I'd just like to get an idea of how long we need to wait before we can use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments