Merged
Conversation
ravishetye
reviewed
Apr 20, 2020
| @@ -0,0 +1,4 @@ | |||
| 1) Re-run "go run github.com/99designs/gqlgen" when you update the schema. | |||
There was a problem hiding this comment.
would it possible to document the structure of the folder, when would one end up updating which file?
| @@ -0,0 +1,5 @@ | |||
| 1) Get the generator `go get github.com/vektah/dataloaden` | |||
There was a problem hiding this comment.
dataloader caches the data, or just batches and optimizes the calls to backend/uac?
we only do it for uac because we anticipate only those calls to have the volume which makes sense to batch?
Contributor
Author
There was a problem hiding this comment.
Just batches and optimizes if the same call happens over and over, like what happens on collaborators (teams and users).
We don't cache anything between calls as permissions and state might have changed. Caching is a nightmare.
| @@ -0,0 +1,6 @@ | |||
| type AllowedActions { | |||
ravishetye
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ravishetye please review the build part and integration with our setup. I have verified with docker compose locally as per screenshot above.