Skip to content

Collections, Content Fixes, Removal of Un-used Code, Code.scss #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2023
Merged

Collections, Content Fixes, Removal of Un-used Code, Code.scss #63

merged 3 commits into from
Dec 26, 2023

Conversation

@VerzatileDev
Copy link
Contributor

@VerzatileDev VerzatileDev commented Dec 26, 2023

Collections

  • Removed "Box-shadow" as it is not nessecariy from each collection block.
  • Add .example tag ( See differences between the one with Code-block and without)
  • Fixed A few Highlights on Text and Titles
  • Has its own File, which is imported in "Custom.scss"

Content

  • Content under C++ Sub Domains, now includes " .example " tags for code-blocks.
  • Fixed areas where .example added an additional "Example " title and removed them such as " ### Example "

Additionally Added

  • Now Includes Code.scss
    • Note that Code.scss is also available on The base of " Just the Docs ", which means that the current one is overwriting elements written there. (Both files are included which should be addressed!)

@VerzatileDev
[Change]Collection Loca, Fix warning calls
6cab073 
Changes the locations of the collections from custom.scss to instead be imported there, to make it easier in the future to maintain.

Which is now in " Collections.scss"

Fixed Language c++ ->
SubDomain pages

On there .warning calls were wrong and wouldn't be displayed on the Website.
It must be included as a title type above the content type.

.warning
content
@VerzatileDev
Code Block, Fix collections
37f0d77 
Collections are now within its own file and can be edited through it.

Along with it a new file has been introduced such as " code.scss " which overwrites the dependency " just the docs " file, there you can edit the contents of code blocks and inside of it.

Also removed unessecary Box shadows from collections tags.
@VerzatileDev
[ADD] .Example Tag
a239943 
Example tag has been included for the specified content written that showcases "Code-Blocks"

Fixed an accident on Addressed.md that changes .warning to .further-reading.

Which has now been addressed.
@VerzatileDev VerzatileDev added 📖 Type: Content Edits to documentation/content. 🌈 Type: Cosmetic Edits to layout or looks. 🌟 Type: Feature New feature or repository request. 👁️ Review: Required This PR is ready for review. ⚠️ Priority: Minor Should be addressed where possible, if there are resources to spare. labels Dec 26, 2023
@VerzatileDev VerzatileDev linked an issue Dec 26, 2023 that may be closed by this pull request
Make an "example" Collection tag ? Which highlights the entirety of the Example in a singular box #62
Closed
JDSherbert
JDSherbert approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@JDSherbert JDSherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JDSherbert JDSherbert merged commit b7031c1 into VerzatileDevOrg:main Dec 26, 2023
@JDSherbert JDSherbert added ✅ Review: Approved PR is approved and ready for merge. and removed 📖 Type: Content Edits to documentation/content. 👁️ Review: Required This PR is ready for review. ⚠️ Priority: Minor Should be addressed where possible, if there are resources to spare. labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JDSherbert JDSherbert JDSherbert approved these changes

@Sommos Sommos Awaiting requested review from Sommos

Assignees

No one assigned

Labels

✅ Review: Approved PR is approved and ready for merge. 🌈 Type: Cosmetic Edits to layout or looks. 🌟 Type: Feature New feature or repository request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make an "example" Collection tag ? Which highlights the entirety of the Example in a singular box

2 participants

@VerzatileDev @JDSherbert