Fix regression in checking if qt is a pointer#993
Merged
Vexu merged 1 commit intoVexu:masterfrom Apr 25, 2026
Merged
Conversation
Vexu
approved these changes
Apr 25, 2026
Owner
Vexu
left a comment
Vexu
left a comment
There was a problem hiding this comment.
I tested this by adding the function signature to the
test/cases/nullability.cintegration test, but it shouldn't result in an error so I'm not sure if it's the right approach.
It is the right approach, those syntax tests are meant test both correct and incorrect syntax.
Nullability annotations on array parameters now work again
Contributor
Author
|
I've added the tests and ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nullability annotations on array parameters now work again.
Please point me to where I should add tests for this.
Closes #989.