Parser: make condExpr work properly in const contexts#995
Open
ehaas wants to merge 2 commits intoVexu:masterfrom
Open
Parser: make condExpr work properly in const contexts#995ehaas wants to merge 2 commits intoVexu:masterfrom
ehaas wants to merge 2 commits intoVexu:masterfrom
Conversation
Don't eval during adjustTypes for condexpr if condition and selected branch are "comptime known". This prevents type adjustment from clobbering the selected value despite the alternative never being evaluated. If the "comptime known" conditions are met, select the appropriate value as the value of the condexpr
|
Confirmed on my end! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the condition and the selected branch of a condExpr are both statically known, make the condExpr have that statically known value. Also fixes parsing of binary conditional expressions (previous issues were masked by casting the result to void in
binary expressions.cI believe this should fix https://codeberg.org/ziglang/translate-c/issues/322