Skip to content

Fix set_beacon packet handling in 1.19->1.18.2#1241

Merged
kennytv merged 1 commit intoViaVersion:masterfrom
riku6460:fix-set-beacon
Apr 7, 2026
Merged

Fix set_beacon packet handling in 1.19->1.18.2#1241
kennytv merged 1 commit intoViaVersion:masterfrom
riku6460:fix-set-beacon

Conversation

@riku6460
Copy link
Copy Markdown
Contributor

@riku6460 riku6460 commented Apr 7, 2026

Handle effect id 0 as null to avoid kicks.
It was sent by <=1.16.1 clients.

Handle effect id 0 as null to avoid kicks.
It was sent by <=1.16.1 clients.
@kennytv
Copy link
Copy Markdown
Member

kennytv commented Apr 7, 2026

Was that a vanilla client?

@riku6460
Copy link
Copy Markdown
Contributor Author

riku6460 commented Apr 7, 2026

Yes, it was a vanilla client. Here is the relevant server log:

log
[03:37:42] [Netty Server IO #1/INFO]: [ViaVersion] PRE : riku6460 SERVERBOUND PLAY: 35 (0x23) -> 35 (0x23) [1.16.1] PacketWrapper{type=null, id=35, values=[], readable=[]}
[03:37:42] [Netty Server IO #1/INFO]: [ViaVersion] POST: riku6460 SERVERBOUND PLAY: 35 (0x23) -> 38 (0x26) [1.16.1] PacketWrapper{type=SET_BEACON, id=38, values=[], readable=[{com.viaversion.viaversion.api.type.types.BooleanType: true}, {VarInt: 1}, {com.viaversion.viaversion.api.typ
e.types.BooleanType: true}, {VarInt: 0}]}
[03:37:42] [Netty Server IO #1/WARN]: io.netty.handler.codec.DecoderException: java.lang.NullPointerException
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:480)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:299)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.flush.FlushConsolidationHandler.channelRead(FlushConsolidationHandler.java:152)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[03:37:42] [Netty Server IO #1/WARN]:   at java.base/java.lang.Thread.run(Thread.java:1474)
[03:37:42] [Netty Server IO #1/WARN]: Caused by: java.lang.NullPointerException
[03:37:42] [Netty Server IO #1/WARN]:   at java.base/java.util.Objects.requireNonNull(Objects.java:220)
[03:37:42] [Netty Server IO #1/WARN]:   at java.base/java.util.Optional.of(Optional.java:113)
[03:37:42] [Netty Server IO #1/WARN]:   at net.minecraft.network.PacketDataSerializer.b(PacketDataSerializer.java:251)
[03:37:42] [Netty Server IO #1/WARN]:   at net.minecraft.network.protocol.game.PacketPlayInBeacon.<init>(PacketPlayInBeacon.java:22)
[03:37:42] [Netty Server IO #1/WARN]:   at net.minecraft.network.EnumProtocol$a.a(EnumProtocol.java:304)
[03:37:42] [Netty Server IO #1/WARN]:   at net.minecraft.network.EnumProtocol.a(EnumProtocol.java:237)
[03:37:42] [Netty Server IO #1/WARN]:   at net.minecraft.network.PacketDecoder.decode(PacketDecoder.java:27)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
[03:37:42] [Netty Server IO #1/WARN]:   at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
[03:37:42] [Netty Server IO #1/WARN]:   ... 44 more

@kennytv kennytv merged commit 827c00f into ViaVersion:master Apr 7, 2026
1 check passed
@riku6460 riku6460 deleted the fix-set-beacon branch April 7, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants