Fix I/O error on exit by closing urlopen response (#72)

[nezhar]

This pull request makes a minor improvement to the _wait_for_datasette function in src/vibepod/commands/logs.py by ensuring that the HTTP response object is properly closed after opening the URL.

• Resource management improvement:
  • Changed to use a with statement when opening the URL in _wait_for_datasette, ensuring the response object is properly closed.

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability and resource management for internal health-check probes to ensure proper cleanup of resources during background monitoring operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6ddac369-e4ca-4a0e-a2a4-ecd865ad5298

📥 Commits

Reviewing files that changed from the base of the PR and between cddc2b6 and 66ed694.

📒 Files selected for processing (1)

• src/vibepod/commands/logs.py

---

📝 Walkthrough

Walkthrough

The PR improves resource management in the datasette health-check routine by wrapping the HTTP request in a context manager. The urlopen response is now properly closed after each probe attempt instead of remaining open, while maintaining identical retry and timeout behavior.

Changes

Health Check Resource Management

Layer / File(s)	Summary
Datasette health check response management src/vibepod/commands/logs.py	HTTP response from the health probe is now closed via context manager, ensuring proper cleanup of the connection after each probe attempt while preserving existing retry logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops down logs divine,
Where datasette probes align,
With context close and cleanup tight,
Resources flow both day and night! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing an I/O error by properly closing the urlopen response using context management.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-72

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[augmentcode]

🤖 Augment PR Summary

Summary: Ensures the Datasette health-check probe doesn’t leave an open HTTP handle, preventing I/O errors during shutdown.

Changes:

• Wraps the `urllib.request.urlopen()` call in `_wait_for_datasette` with a context manager so the response is always closed on success.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.