Request for check #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return currentSum; | ||
| } | ||
|
|
||
| public boolean addItem(Item item) { |
There was a problem hiding this comment.
🍏 Можно вместо boolean добавить void и убрать return, т.к. возвращаемое значение у тебя нигде не используется
Comment on lines
+13
to
+19
| if (lastDigit == 1) { | ||
| rublesValue = "рубль"; | ||
| } else if (lastDigit >= 2 && lastDigit <= 4) { | ||
| rublesValue = "рубля"; | ||
| } else { | ||
| rublesValue = "рублей"; | ||
| } |
There was a problem hiding this comment.
🍏 Такого рода блоки, как if-then-else, в Java можно заменить на switch case. Дело вкуса
| @@ -0,0 +1,39 @@ | |||
| public class Item { | |||
There was a problem hiding this comment.
Круто, что используешь класс, как модель данных для описания товара 👍
Comment on lines
+18
to
+37
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
|
|
||
| Item item = (Item) o; | ||
|
|
||
| if (Double.compare(item.price, price) != 0) return false; | ||
| return name != null ? name.equals(item.name) : item.name == null; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result; | ||
| long temp; | ||
| result = name != null ? name.hashCode() : 0; | ||
| temp = Double.doubleToLongBits(price); | ||
| result = 31 * result + (int) (temp ^ (temp >>> 32)); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
Весьма полезное решение переопределять hashCode и equals 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.