Merged
Conversation
dyiar
reviewed
Jun 4, 2019
| if (arr[j] < smallest): | ||
| smallest = arr[j] | ||
| smallest_index = j | ||
| arr[i], arr[smallest_index] = smallest, current |
| def bubble_sort( arr ): | ||
|
|
||
| def bubble_sort(arr): | ||
| boolean = True |
Collaborator
There was a problem hiding this comment.
so proud to see you using the boolean and while loop. More than a couple people here didn't haha
dyiar
reviewed
Jun 5, 2019
| arrA.pop(0) | ||
| while len(arrB) > 0: | ||
| merged_arr.append(arrB[0]) | ||
| arrB.pop(0) |
Collaborator
There was a problem hiding this comment.
I like the way you implemented this. Good job
| if (len(arr) <= 1): | ||
| return arr | ||
| else: | ||
| midpoint = math.floor(len(arr) / 2) |
Collaborator
There was a problem hiding this comment.
I can't remember if // does this in every language or if it is just a python thing, but len(arr) // 2 is the same as math.floor(len(arr)/2)
| else: | ||
| midpoint = math.floor(len(arr) / 2) | ||
| left = arr[0:midpoint] | ||
| right = arr[midpoint:len(arr)] |
Collaborator
There was a problem hiding this comment.
to save lines you could condense these and do left = merge_sort(arr[0:midpoint]) and right = merge_sort(arr[midpoint:])
Good job with these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.