app/vmui: add CI workflow for vmui with lint, typecheck, and testing#461
Merged
app/vmui: add CI workflow for vmui with lint, typecheck, and testing#461
Conversation
arturminchukov
force-pushed
the
vlogs/vmui-add-ci-workflow
branch
from
164d69e to
aa8b332
Compare
arturminchukov
force-pushed
the
vlogs/vmui-add-ci-workflow
branch
from
aa8b332 to
86127c4
Compare
arturminchukov
added
the
web-ui
valyala
approved these changes
Jul 17, 2025
Contributor
valyala
left a comment
valyala
left a comment
There was a problem hiding this comment.
Looks good. I'll remove the cluster branch name in a follow up commit, since VictoriaLogs repository has no cluster branch - all the cluster-related code is located in the master branch.
Contributor
|
@arturminchukov , thank you for the pull request! |
Contributor
valyala
added a commit
that referenced
this pull request
Dec 20, 2025
…e commit d9000a98bedd9f9720348ea4221ad9d22ea7871b, since all the npm commands are executed inside Docker container Updates #461
Contributor
|
@arturminchukov , @Loori-R , please see the follow-up commits 761af98 and 7ebba6d . These commits remove the requirement to install node on the host machine before running Please make the same changes in VictoriaMetrics and VictoriaTraces repositories. |
Contributor
|
Please see also the follow-up commit 77526cd |
caicancai
pushed a commit
to caicancai/VictoriaLogs
that referenced
this pull request
Jan 30, 2026
I don't want polluting my computer with npm shit. It must run in Docker container. This allows running all the vmui-* Makefile rules without the need to install npm on the host. This is a follow-up for the commit eabb2d7 Updates VictoriaMetrics#461
caicancai
pushed a commit
to caicancai/VictoriaLogs
that referenced
this pull request
Jan 30, 2026
…e commit d9000a98bedd9f9720348ea4221ad9d22ea7871b, since all the npm commands are executed inside Docker container Updates VictoriaMetrics#461
caicancai
pushed a commit
to caicancai/VictoriaLogs
that referenced
this pull request
Jan 30, 2026
…e to vmui-run-npm-command rule, since it depends on the vmui-package-base-image This is a follow-up for the commit 761af98 Updates VictoriaMetrics#461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Added CI workflow for vmui checks: lint, typecheck, testing
Checklist
The following checks are mandatory: