Skip to content

refactoring: move common shard logic#1602

Merged
f41gh7 merged 1 commit intomasterfrom
move-common-shard-logic
Nov 7, 2025
Merged

refactoring: move common shard logic#1602
f41gh7 merged 1 commit intomasterfrom
move-common-shard-logic

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Nov 6, 2025

moved common sharding logic into build package
extracted from #1554

@AndrewChubatiuk AndrewChubatiuk force-pushed the move-common-shard-logic branch 4 times, most recently from 397c9b8 to 5ee49a1 Compare November 6, 2025 20:10
@AndrewChubatiuk AndrewChubatiuk force-pushed the move-common-shard-logic branch from 5ee49a1 to 4b03620 Compare November 7, 2025 08:46
Copy link
Copy Markdown
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix test:

 [FAILED] Timed out after 80.001s.
  Expected success, but got an error:
      <*errors.errorString | 0xc000fe26d0>: 
      not expected object status="failed", reason="cannot reconcile sts for vmagent(0): cannot handle rolling-update on sts: vmagent-stateful-shard-0, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration",conditions=
      {
          s: "not expected object status=\"failed\", reason=\"cannot reconcile sts for vmagent(0): cannot handle rolling-update on sts: vmagent-stateful-shard-0, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration\",conditions=",
      }
  In [It] at: /home/runner/work/operator/operator/test/e2e/vmagent_test.go:431 @ 11/07/25 09:05:17.698
------------------------------
•••••
------------------------------
• [FAILED] [293.420 seconds]
test vmanomaly Controller e2e vmanomaly should update exist vmanomaly [It] by switching to shard mode [vm, anomaly, enterprise]
/home/runner/work/operator/operator/test/e2e/vmanomaly_test.go:329

  [FAILED] Timed out after 240.001s.
  Expected success, but got an error:
      <*errors.errorString | 0xc0003879b0>: 
      not expected object status="failed", reason="cannot handle rolling-update on sts: vmanomaly-shard-0, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration\ncannot handle rolling-update on sts: vmanomaly-shard-1, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration",conditions=
      {
          s: "not expected object status=\"failed\", reason=\"cannot handle rolling-update on sts: vmanomaly-shard-0, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration\\ncannot handle rolling-update on sts: vmanomaly-shard-1, err: actual pod count: 0 less than needed: 1, possible statefulset misconfiguration\",conditions=",
      }

@f41gh7 f41gh7 merged commit 9bbfa71 into master Nov 7, 2025
6 of 7 checks passed
@f41gh7 f41gh7 deleted the move-common-shard-logic branch November 7, 2025 10:01
@f41gh7
Copy link
Copy Markdown
Collaborator

f41gh7 commented Nov 7, 2025

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants