vmuser: fixed object key generation

[AndrewChubatiuk]

follow up for #1686

---

Summary by cubic

Fixed VMUser key generation to include the namespace and handle bearer token/basic auth consistently. Prevents key collisions and correctly masks sensitive values.

• Bug Fixes
  • Prefix keys with namespace to ensure uniqueness.
  • Prefer bearerToken; otherwise use username or fallback to resource name for basicAuth.
  • Append password for basicAuth when present and apply masking via a single helper when hide is true.

^{Written for commit d5a7a63. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="api/operator/v1beta1/vmuser_types.go">

<violation number="1" location="api/operator/v1beta1/vmuser_types.go:291">
P2: `cr.Name` is Kubernetes object metadata (not a secret) and should not be passed to `hideFn`. When `hide=true` is used for error messages (e.g., duplicate detection), hiding the object name makes debugging harder since users can't identify which objects are conflicting.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}