Skip to content

vmalert: fail on absent notifiers#1761

Merged
vrutkovs merged 1 commit intomasterfrom
vmalert-fail-on-empty-notifiers
Jan 28, 2026
Merged

vmalert: fail on absent notifiers#1761
vrutkovs merged 1 commit intomasterfrom
vmalert-fail-on-empty-notifiers

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Jan 27, 2026

fixes #1757


Summary by cubic

vmalert now returns an error if no notifier targets are found, instead of starting with an empty -notifier.url. This prevents silent misconfigurations; ExtraArgs notifier.url/notifier.config are respected. Fixes #1757.

  • Bug Fixes

    • Return error when no notifiers are discovered via selectors or static config.
    • Do not append empty -notifier.url; use ExtraArgs notifier.url or notifier.config when provided.
    • Updated tests to reflect new behavior.
  • Migration

    • Configure notifiers via spec.notifiers/spec.notifier, or set ExtraArgs: notifier.url or notifier.config.
    • Deployments that previously ran without notifiers will now fail until configured.

Written for commit fa4f447. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:20">
P1: Rule violated: **Changelog Review Agent**

Changelog entries must describe the user-visible behavior before and after the change and avoid internal implementation details. This entry only states an internal action (“throw error”) without explaining prior behavior or the user-facing improvement, so it violates the required structure.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Collaborator

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks e2e tests now

@AndrewChubatiuk AndrewChubatiuk force-pushed the vmalert-fail-on-empty-notifiers branch from 455f1d4 to fa4f447 Compare January 27, 2026 18:20
@AndrewChubatiuk
Copy link
Contributor Author

fixed tests

@vrutkovs vrutkovs merged commit 0d4f73d into master Jan 28, 2026
6 checks passed
@vrutkovs vrutkovs deleted the vmalert-fail-on-empty-notifiers branch January 28, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vmalert: using notifiers selector which do not match vmalertmanager

2 participants