Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:20">
P1: Rule violated: **Changelog Review Agent**
Changelog entries must describe the user-visible behavior before and after the change and avoid internal implementation details. This entry only states an internal action (“throw error”) without explaining prior behavior or the user-facing improvement, so it violates the required structure.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
vrutkovs
approved these changes
Jan 27, 2026
vrutkovs
requested changes
Jan 27, 2026
Collaborator
vrutkovs
left a comment
There was a problem hiding this comment.
This breaks e2e tests now
455f1d4 to
fa4f447
Compare
Contributor
Author
|
fixed tests |
vrutkovs
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1757
Summary by cubic
vmalert now returns an error if no notifier targets are found, instead of starting with an empty -notifier.url. This prevents silent misconfigurations; ExtraArgs notifier.url/notifier.config are respected. Fixes #1757.
Bug Fixes
Migration
Written for commit fa4f447. Summary will update on new commits.