Conversation
a821fa5 to
c84f178
Compare
Contributor
There was a problem hiding this comment.
2 issues found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="api/operator/v1beta1/vmauth_types.go">
<violation number="1" location="api/operator/v1beta1/vmauth_types.go:226">
P2: Validation ignores src_headers. A URL map that only sets src_headers will still fail the “at least one must be defined” check because SrcHeaders isn’t included in the condition. Include SrcHeaders in the empty check to match the error message and intended behavior.</violation>
</file>
<file name="docs/templates/api/type.tpl">
<violation number="1" location="docs/templates/api/type.tpl:37">
P3: Use a valid HTML line break tag instead of `</br>`; `<br/>` is the correct void element syntax.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
3e6c3ea to
2eb62fc
Compare
Member
Collaborator
That seems to duplicate CHANGELOG functionality. Also, our docs are for the latest released version only, so this tag is useless for docs too. What other purposes for this tag do you see? |
vrutkovs
reviewed
Jan 30, 2026
Contributor
Author
it's hard to check changelog each time you need to enable a new property |
2eb62fc to
f67f1c2
Compare
vrutkovs
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated all tools in makefile

replaced
Deprecated:prefixed comments with customdeprecatedmarkers that are rendered as shown below@makasim @vrutkovs what do you think about adding the same
+releasedmarker to inform about release since which parameter is available?Summary by cubic
Upgraded build tools and improved API/CRD docs by switching to custom deprecated markers and a pinned crd-ref-docs fork. Also increased doc render depth and regenerated client/informer code to v0.35 with context-aware watch support.
Refactors
Dependencies
Written for commit f67f1c2. Summary will update on new commits.