reconcile: delete statefulset pods when maxUnavailable set to 100%

[AndrewChubatiuk]

fixes #1706

---

Summary by cubic

Switch StatefulSet rollouts to delete pods when maxUnavailable is 100% for faster, predictable full restarts that aren’t blocked by PDBs. Tests are simplified with controller-runtime client interceptors and testify, removing go-test/deep, and adding coverage for the delete path and PDB behavior.

• New Features

  • Delete pods instead of evicting during OnDelete StatefulSet updates when maxUnavailable=100% (deletion ignores PDBs); otherwise evict in batches sized by MaxUnavailable.

• Bug Fixes

  • Treat not-found on delete as success.
  • Ignore terminating pods and non-StatefulSet-owned pods during update checks to avoid false failures.

^{Written for commit 6eae380. Summary will update on new commits.}

[cubic-dev-ai]

3 issues found across 15 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/reconcile/statefulset.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset.go:171">
P0: Nil pointer dereference: `cr.UpdateBehavior` can be nil here. The nil guard on line 160 only protects the `GetScaledValueFromIntOrPercent` call, but this new check is outside that guard. When no `UpdateBehavior` is configured (the default), this will panic at runtime.</violation>

<violation number="2" location="internal/controller/operator/factory/reconcile/statefulset.go:373">
P1: Variable shadowing bug: inner `var pod corev1.Pod` (line 373) shadows the outer `var pod *corev1.Pod` (line 371). The outer `pod` remains nil forever, making `podStatusesToError` dead code. On poll timeout, the enriched error diagnostics (pod phase, conditions, container crash states) are silently lost. Change the inner declaration to assign to the outer variable, as the old code did.</violation>
</file>

<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:31">
P3: Fix the typo "importaint" → "important" in this changelog entry to keep documentation polished.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[AndrewChubatiuk]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

2 issues found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:31">
P2: Custom agent: **Changelog Review Agent**

The new changelog entry doesn’t follow the required structure: it lacks an explicit before/now user-visible explanation and focuses on implementation details (deletion vs eviction). The Changelog Review Agent rule requires a user-centric before/after description of the impact.</violation>
</file>

<file name="internal/controller/operator/factory/reconcile/statefulset.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset.go:165">
P2: The delete mode won’t activate for the intended "100%" maxUnavailable because IntValue() returns 0 for percentage strings like "100%". Check the string value/type instead so the 100% case is detected.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[AndrewChubatiuk]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 7 files