reconcile: properly handle parsing and get errors for prom objects#2036
Merged
AndrewChubatiuk merged 2 commits intomasterfrom Apr 13, 2026
Merged
reconcile: properly handle parsing and get errors for prom objects#2036AndrewChubatiuk merged 2 commits intomasterfrom
AndrewChubatiuk merged 2 commits intomasterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vrutkovs
approved these changes
Apr 13, 2026
vrutkovs
added a commit
that referenced
this pull request
Apr 17, 2026
…2036) * reconcile: properly handle parsing and get errors for prom objects * test: add tests for ReconcileErrWithStatus --------- Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Improve reconcile error handling for Prometheus and VictoriaMetrics controllers. Parsing errors are detected and reported correctly, metrics are labeled accurately, and VM CRDs set status to Failed on parse failures.
handleReconcileErrWithStatusupdates VM CRD status on parse errors; Prom reconcilers defer error handling and convert conversion failures to parsing errors.parseObjectErrorsTotal,getObjectsErrorsTotal, andconflictErrorsTotal; deregister collectors on get errors; ignore not-found.handleReconcileErrWithStatuscovering nil, parsing error, context canceled, and transient cases.Written for commit 774382a. Summary will update on new commits.