vmbackup: add eula flag for upgrade tests

[AndrewChubatiuk]

Summary by cubic

Add acceptEula support for VMBackup/VMRestore and set it in upgrade tests for v1.136.0-enterprise. Also render empty extraArgs as -flag and update the CHANGELOG with EULA migration guidance.

• Migration
  • VMCluster: set spec.vmstorage.vmBackup.acceptEula: true to avoid rollouts; migrate to spec.license during upgrade.
  • VMSingle: set spec.vmBackup.acceptEula: true to avoid rollouts; migrate to spec.license during upgrade.

^{Written for commit 0a33bdf. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:20">
P1: Custom agent: **Changelog Review Agent**

This new changelog item is not in the required `FEATURE`/`BUGFIX`/`SECURITY` entry format and omits mandatory references, so it fails the changelog gatekeeper structure requirements.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P1: Custom agent: Changelog Review Agent

This new changelog item is not in the required FEATURE/BUGFIX/SECURITY entry format and omits mandatory references, so it fails the changelog gatekeeper structure requirements.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 20:

<comment>This new changelog item is not in the required `FEATURE`/`BUGFIX`/`SECURITY` entry format and omits mandatory references, so it fails the changelog gatekeeper structure requirements.</comment>

<file context>
@@ -17,6 +17,7 @@ aliases:
 **Update note 1**: deprecated env variables for Prometheus CRs conversion `VM_ENABLEDPROMETHEUSCONVERTER_PODMONITOR`, `VM_ENABLEDPROMETHEUSCONVERTER_SERVICESCRAPE`, `VM_ENABLEDPROMETHEUSCONVERTER_PROMETHEUSRULE`, `VM_ENABLEDPROMETHEUSCONVERTER_PROBE`, `VM_ENABLEDPROMETHEUSCONVERTER_SCRAPECONFIG`. Use `-controller.disableReconcileFor` command-line flag with comma-separated list of controller names, that should be disabled.
 **Update note 2**: removed `operator_prometheus_converter_watch_events_total` metric since migration of Prometheus object watchers to controllers made this counter obsolete.
 **Update note 3**: made `controller.prometheusCRD.resyncPeriod` command line flag noop, which was relevant to Prometheus object watchers.
+**Update note 4**: `-eula` flag was completely removed from VMBackup and VMRestore. To avoid VMCluster/VMSingle rollouts set `spec.vmstorage.vmBackup.extraArgs["eula"]: ""` for VMCluster and `spec.vmBackup.extraArgs["eula"]: ""` for VMSingle.
 
 * Dependency: [vmoperator](https://docs.victoriametrics.com/operator/): Updated default versions for VM apps to [v1.139.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.139.0) version
</file context>

[AndrewChubatiuk]

Update note <number>: prefix is a common practice in victoriametrics to notify users about behaviour change or some breaking changes

[cubic-dev-ai]

Thanks for the feedback! I already have a similar learning that covers this, so I'm keeping the existing one.