use existing volume if it's name matches sts volume claim template#2066
Merged
AndrewChubatiuk merged 3 commits intomasterfrom Apr 16, 2026
Merged
use existing volume if it's name matches sts volume claim template#2066AndrewChubatiuk merged 3 commits intomasterfrom
AndrewChubatiuk merged 3 commits intomasterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…r: use existing volume if it's name matches sts volume claim template
AndrewChubatiuk
force-pushed
the
use-existing-volume-if-name-matches
branch
from
a67fffc to
555354e
Compare
vrutkovs
approved these changes
Apr 16, 2026
AndrewChubatiuk
added a commit
that referenced
this pull request
Apr 16, 2026
…2066) * vmagent/vmcluster/vlcluster/vtcluster/vlagent/vmanomaly/vmalertmanager: use existing volume if it's name matches sts volume claim template * chore: fetch volume quicker * test: add tests for StorageVolumeMountsTo --------- Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
AndrewChubatiuk
added a commit
that referenced
this pull request
Apr 16, 2026
…2066) * vmagent/vmcluster/vlcluster/vtcluster/vlagent/vmanomaly/vmalertmanager: use existing volume if it's name matches sts volume claim template * chore: fetch volume quicker * test: add tests for StorageVolumeMountsTo --------- Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skips emptyDir mount of already defined volume matches default expected volumeClaimTemplate (VMStorage pod can't start when an additional volume mount to the storageDataPath #784 and How to disable using of /cache pvc in the vmselect operator api ? #810)
Summary by cubic
Use existing user-defined volumes when their names match the default data/cache volume names instead of auto-creating and mounting emptyDir/PVC. This fixes persistent storage mounts across StatefulSet-based CRs and vmagent in DaemonSet mode, and prevents config conflicts.
Bug Fixes
persistent-queue-datafrom spec.volumes; stop mounting emptyDir. See VMAgent DaemonSetMode: volumes/volumeMounts not working properly #1677.vmstorage-dbfrom spec.vmstorage.volumes andvmselect-cachedirfrom spec.vmselect.volumes for storage/cache. See VMStorage pod can't start when an additional volume mount to the storageDataPath #784.storage.emptyDiror a volumeClaimTemplate.Refactors
StorageVolumeMountsTo, vmagent DaemonSet, and vmcluster volume reuse.Written for commit 04b5a72. Summary will update on new commits.